Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go 1.15.x and upgrade dependencies #502

Merged
merged 3 commits into from
Sep 23, 2020

Conversation

tomer-stripe
Copy link
Collaborator

Reviewers

r? @ob-stripe @richardm-stripe
cc @stripe/developer-products

Summary

Upgrade go version and dependencies. goreleaser deprecated github in favor of tap (https://goreleaser.com/deprecations#brewsgithub) so I'm updating that before it breaks anything.

Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving the final review to @richardm-stripe, but lgtm!

@ob-stripe ob-stripe removed their assignment Sep 16, 2020
@tomer-stripe
Copy link
Collaborator Author

ptal @pepin-stripe

Since you're spinning up here!

Copy link
Contributor

@pepin-stripe pepin-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me too - I assume most of those are automatically generated?

Copy link
Contributor

@pepin-stripe pepin-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry meant to approve!

@tomer-stripe
Copy link
Collaborator Author

tomer-stripe commented Sep 23, 2020

@pepin-stripe yep!

merging! changes were a rebase after merging in #503

@tomer-stripe tomer-stripe merged commit e3eb1e3 into master Sep 23, 2020
@tomer-stripe tomer-stripe deleted the tomer/upgrade-to-go-1.15.x branch September 23, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants