Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo goreleaser config change for homebrew #510

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

tomer-stripe
Copy link
Collaborator

Reviewers

r? @pepin-stripe
cc @stripe/developer-products

Summary

We're using goreleaser-xcgo to run goreleaser in docker on Travis (due to previous issues. That docker image is running version 0.127.0, which doesn't include the new syntax that I updated to in #502. I don't want to try to update the version on the docker image so I'm undoing this one syntax change for now.

Copy link
Contributor

@pepin-stripe pepin-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what that means or how it works, but LGTM?

@tomer-stripe tomer-stripe merged commit be21964 into master Sep 30, 2020
@tomer-stripe tomer-stripe deleted the tomer/undo-goreleaser-change branch September 30, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants