-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use the new protobuf library #908
Conversation
@gracegoo-stripe @vcheung-stripe if y'all have time could you double check that this works? I ran things locally and they seem fine but you have more familiarity in this area than I do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally by editing version.proto and running make protoc
, but the proto compiler wasn't able to see my changes. Looking into it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Reviewers
r? @vcheung-stripe @gracegoo-stripe
cc @stripe/developer-products
Summary
This updates our proto pipeline to use the latest protobuf/protoc libraries and dependencies. notably, the github.com dependencies were deprecated and superseded by the google-specific ones.