Remove extension methods #1511
Merged
Remove extension methods #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haha, nice. LGTM! |
|
This looks good but deferring to Brandur as usual for those core changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe @brandur-stripe
Remember those fancy extension methods I added in #1478? Well, they're gone already.
BaseOptionsExtensions.ToQueryString()was no longer used in the library after all the requestor code refactoring, only in testsServiceExtensions.Expansions()was only used in theServiceclass itself, so it didn't make sense for it to be an extension method. It's now a regular class method.This PR also adds the ability to pass a custom Stripe client to service instances, and uses this for testing the now private
Expansions()method.