Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check validity of JSON in OK responses #1536

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Check validity of JSON in OK responses #1536

merged 1 commit into from
Feb 22, 2019

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe

Checks the validity of JSON in OK responses, and throw a StripeException if invalid. I already added this for error responses in #1518.

Partially fixes #1507.

@ob-stripe ob-stripe mentioned this pull request Feb 21, 2019
Merged
52 tasks
remi-stripe
remi-stripe approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand what this fixes, in the sense that our API should really only ever return JSON and if it doesn't it's a bug we should fix server-side. But ultimately this is basically making the error explicit now which is better.

@remi-stripe remi-stripe assigned ob-stripe and unassigned remi-stripe Feb 22, 2019
@ob-stripe ob-stripe merged commit 31d32e0 into integration-v23 Feb 22, 2019
@ob-stripe ob-stripe deleted the ob-check-valid-json branch February 22, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ob-stripe @remi-stripe