Add support for CreditNote #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-credit-notes
branch
2 times, most recently
from
3ee4f6d
to
a882abc
Compare
remi-stripe
force-pushed
the
remi-add-credit-notes
branch
from
a882abc
to
f231ff8
Compare
|
r? @ob-stripe |
ob-stripe
suggested changes
Apr 17, 2019
remi-stripe
changed the title
|
@ob-stripe Thanks for the review. I made some changes (and added 2 missing fields). I did not force push to make the re-review easier (and I'll squash after approval). Can you re-r? the last 2 commits? |
ob-stripe
approved these changes
Apr 17, 2019
Yep those are tricky to align unfortunately, I originally missed them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @stripe/api-libraries