Add support for the SetupIntent resource and APIs
#1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
force-pushed
the
remi-add-setup-intents
branch
3 times, most recently
from
8818fe2
to
9202500
Compare
remi-stripe
changed the title
SetupIntent resource and APIsSetupIntent resource and APIs
remi-stripe
commented
Jun 27, 2019
| /// retrieve the setup intent. | ||
| /// </summary> | ||
| [JsonProperty("client_secret")] | ||
| public string ClientSecret { get; set; } |
There was a problem hiding this comment.
I kept those since some developers use our library in mobile apps
remi-stripe
changed the title
SetupIntent resource and APIsSetupIntent resource and APIs
|
re-assigning to myself as there's a breaking change being merged in. |
remi-stripe
force-pushed
the
remi-add-setup-intents
branch
from
9202500
to
4f03376
Compare
remi-stripe
changed the title
SetupIntent resource and APIsSetupIntent resource and APIs
brandur-stripe
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not add the docs because the strings are not finalized. I will commit to fixing those (and the PaymentIntent ones) after the API is public. We would like to merge ahead of that though.
r? @ob-stripe
cc @stripe/api-libraries @danwang-stripe