Init options with forced parameter values #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
While I'm okay with the change, I think this is a breaking change. While the current behaviour is a bug, changing it would change the number of results returned in List endpoints.
Also we really should consider adding something that can fetch a list of IPaymentSource like we have (or used to?) in java. Not being able to list all payment sources (I can't say payment methods though I want to) is really confusing.
|
+1 Remi's comments, but LGTM otherwise. (Thanks for the quick fix!) |
ob-stripe
added a commit
that referenced
this pull request
Jul 18, 2019
remi-stripe
pushed a commit
that referenced
this pull request
Jul 19, 2019
remi-stripe
pushed a commit
that referenced
this pull request
Aug 12, 2019
ob-stripe
added a commit
that referenced
this pull request
Aug 16, 2019
ob-stripe
added a commit
that referenced
this pull request
Sep 30, 2019
ob-stripe
added a commit
that referenced
this pull request
Oct 7, 2019
ob-stripe
added a commit
that referenced
this pull request
Oct 8, 2019
ob-stripe
added a commit
that referenced
this pull request
Oct 9, 2019
* Better string enums (#1675) * Init options with default parameter values (#1699) * Remove multiple deprecated features (#1713) Many features were marked as obsolete and are now being removed: * AccountBalance on Customer, use Balance instead * Billing on Subscription/Invoice/SubscriptionSchedule, use CollectionMethod instead * TaxInfo and TaxInfoVerification on Customer, use TaxId instead * AllowedSourceTypes on PaymentIntent, use PaymentMethodTypes instead * Start on Subscription, use StartDate instead * ApplicationFee on Charge, use ApplicationFeeAmount instead * Date when listing Invoices, use Created instead * OperatorAccount on all Terminal APIs * Remove all Expand* fields (#1715) * Use properl SetupIntent class * Removed Id and FileId suffixes to stay as close to the API as possible. (#1738) * Add a test to ensure that JSON names match property names (#1744) * A few more renames (#1739) * Remove dead code for service expansions (#1751) * Bump Stylecop.Analyzers to latest version (#1752) * Bump SourceLink and create symbol package (#1755) * Fix all classes not inheriting from the generic version of StripeEntity * Add a wholesome test to ensure proper JSON converters are applied (#1761) * Remove more deprecated stuff (#1802) * Remove more Id/FileId suffixes (#1803) * One more rename (#1805) * Fix ExternalAccountUpdateOptions (#1806) * Rename AccountOpener to Representative and move to latest API version * Enable test for JSON<->property name consistency (#1804)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @remi-stripe @brandur-stripe
Some options classes have forced parameter values, e.g.
CardListOptionsalways includesobject=card. However if the user passesnullthen the parameter is not sent.This is kind of an ugly ad-hoc fix. Ideally we would always create an instance of the appropriate options class, but doing this would require us to make all the helper methods in
Servicegeneric to accept the options class as a type param, and I'd rather not do that just yet.Fixes #1676.