A few Billing changes #1758
Merged
A few Billing changes #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
suggested changes
Aug 21, 2019
remi-stripe
force-pushed
the
remi-fix-schedules-again
branch
from
a26afe1
to
f6a207e
Compare
|
Fixed, PTAL |
ob-stripe
suggested changes
Aug 21, 2019
remi-stripe
force-pushed
the
remi-fix-schedules-again
branch
from
f6a207e
to
aaeb5fe
Compare
|
Fixed, PTAL. |
remi-stripe
force-pushed
the
remi-fix-schedules-again
branch
from
aaeb5fe
to
9e4c969
Compare
|
Won't merge until stripe-java is ready so that we can triple-check the changes. |
* Add `Schedule` to `Subscription` * Add missing parameters to `UpcomingInvoiceOptions` and `UpcomingInvoiceListLineItemsOptions` * `Schedule` * `SubscriptionCancelAt` * `SubscriptionCancelNow` * Add missing properties and parameters for a `SubscriptionSchedule` phase: * `BillingThresholds` * `CollectionMethod` * `DefaultPaymentMethod` * `InvoiceSettings`
remi-stripe
force-pushed
the
remi-fix-schedules-again
branch
from
9e4c969
to
153dc3e
Compare
ob-stripe
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1757 and other things I found:
A few Billing changes
ScheduletoSubscriptionUpcomingInvoiceOptionsandUpcomingInvoiceListLineItemsOptionsScheduleSubscriptionCancelAtSubscriptionCancelNowSubscriptionSchedulephase:BillingThresholdsCollectionMethodDefaultPaymentMethodInvoiceSettingsr? @ob-stripe
cc @stripe/api-libraries