Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add various API changes #1814

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Add various API changes #1814

merged 1 commit into from
Oct 18, 2019

Conversation

remi-stripe
Copy link
Contributor

@remi-stripe remi-stripe commented Oct 18, 2019 •
edited
Loading

r? @ob-stripe
cc @stripe/api-libraries

This PR adds multiple changes

  • Requirements and IsDefault on Issuing Cardholder.
  • Fix the name of PhoneNumber on Issuing Cardholder.
  • PaymentMethodDetails.AuBecsDebit on Charge.
  • PaymentBehavior on SubscriptionItem creation is now supported.
  • SubscriptionData.TrialFromPlan is now supported on Checkout Session creation.

ob-stripe
ob-stripe approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You might want to edit the XML comment for TaxId.Type to document the new za_vat value, but up to you.

@stripe-ci stripe-ci assigned remi-stripe and unassigned ob-stripe Oct 18, 2019
@remi-stripe remi-stripe merged commit 04e4969 into master Oct 18, 2019
@remi-stripe remi-stripe deleted the remi-add-various-changes branch October 18, 2019 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ob-stripe ob-stripe ob-stripe approved these changes

Assignees

@remi-stripe remi-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@remi-stripe @ob-stripe @stripe-ci