Exposing the StripeTypeRegistry.ObjectsToTypes publicly #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k payload without parsing the event.
Merging stripe-dotnet/master
Merging stripe.net master branch
ob-stripe
suggested changes
Dec 14, 2019
There was a problem hiding this comment.
Hi @clement911, thanks for the contribution!
I'm fine with this change. Could you just move the StripeTypeRegistry.cs file in src/Stripe.net/Infrastructure/Public, since it's not public? (The directory structure is a bit weird/uncommon.)
Could you also make a similar change for the test file, i.e. src/StripeTests/Infrastructure/StripeTypeRegistryTest.cs -> src/StripeTests/Infrastructure/Public/StripeTypeRegistryTest.cs? Thanks!
|
Sure it makes sense. |
ob-stripe
approved these changes
Dec 17, 2019
|
Thanks! We'll merge and release this soon. |
|
Released as 34.6.0. |
|
Thank you this is very useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are building some highly generic stripe components internally that will need a mapping from object to type.
Rather than maintaining our own, we'd prefer to leverage the one already existing in the library.
I wrapped the dictionary in a read only dictionary so that it can't be modified by consumers.