-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposing the StripeTypeRegistry.ObjectsToTypes publicly #1881
Conversation
…k payload without parsing the event.
Merging stripe-dotnet/master
Merging stripe.net master branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @clement911, thanks for the contribution!
I'm fine with this change. Could you just move the StripeTypeRegistry.cs
file in src/Stripe.net/Infrastructure/Public
, since it's not public? (The directory structure is a bit weird/uncommon.)
Could you also make a similar change for the test file, i.e. src/StripeTests/Infrastructure/StripeTypeRegistryTest.cs
-> src/StripeTests/Infrastructure/Public/StripeTypeRegistryTest.cs
? Thanks!
Sure it makes sense. |
Thanks! We'll merge and release this soon. |
Released as 34.6.0. |
Thank you this is very useful! |
We are building some highly generic stripe components internally that will need a mapping from object to type.
Rather than maintaining our own, we'd prefer to leverage the one already existing in the library.
I wrapped the dictionary in a read only dictionary so that it can't be modified by consumers.