Add support for Network on Charge
#1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
Dec 4, 2019
| @@ -39,6 +39,23 @@ const ( | |||
| PaymentMethodCardBrandVisa PaymentMethodCardBrand = "visa" | |||
| ) | |||
|
|
|||
| // PaymentMethodCardNetwork is the list of allowed values to represent the network | |||
| // used for a card-like transaction. | |||
| type PaymentMethodCardNetwork string | |||
There was a problem hiding this comment.
I made a call here on where to set the enum. I am not sure this is the right decision in the library. In a "normal" world we'd name if ChargePaymentMethodDetailsCardNetwork and it'd be specific, and duplicated for CardPresent, but in the future the network will be chosen for a PI and that will make us rename it.
Long story short: we need to figure out clear rules on how to name enums.
ob-stripe
approved these changes
Dec 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the java one but not touching
SourceTransactionas stripe-go doesn't support the hash specific for now and since this is low usage I want to avoid adding features that will go away in the future.r? @richardm-stripe
cc @stripe/api-libraries