Begin codegenning 5 files #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
reviewed
Mar 9, 2021
There was a problem hiding this comment.
Very cool man! I love that codegen ends up catching a couple unintentional alphabetization errors and the like too.
Left one comment about ... comments, but LGTM otherwise.
ptal @richardm-stripe
| @@ -1,3 +1,4 @@ | |||
| // File generated from our OpenAPI spec | |||
There was a problem hiding this comment.
You might have seen this in lint already, but comments in Go above a package definition like this are actually meaningful documentation that gets included automatically in Godoc. I think you may want to move this to a block right underneath of package stripe (or something).
Also, nit, but could we make this flag a bit bigger so that it's easier to spot when you're visually scanning the file? Like just more empty lines on either side of it or something like that:
//
//
// File generated from our OpenAPI spec
//
//
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
We are beginning to automatically generate parts of
stripe-go. This PR adds five of the files that were simplest to support.ObjectandDeletedproperties. These properties are present on many stripe resources and should be present, but in the past it appears we occasionally omit them as the user need for them is quite rare.