Log only to info on 402 errors from Stripe #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #869, breaks apart how Stripe errors are logged so that status 402 errors go to info instead of error. This is meant to signal that those errors are probably prompted by user data (as opposed to sending invalid parameters or something), and handling them differently allows integrations to avoid filling their error logs with messages that they can't really prevent. Fixes #869.
ob-stripe
approved these changes
Jun 18, 2019
|
Thanks OB! |
mickeyreiss
reviewed
Jun 18, 2019
| // comply to the letter of the specification and uses it in a broader | ||
| // sense. | ||
| if res.StatusCode == 402 { | ||
| s.LeveledLogger.Infof("User-compelled request error from Stripe: %v", |
There was a problem hiding this comment.
I find the wording here a bit confusing. Maybe a standard format could help, along the lines of:
“Stripe request GET /blah returned 402 User Error: Invalid Card Expiration”
With method, path, status, status text and error message being placeholders?
|
LGTM otherwise, solving the problem from the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #869, breaks apart how Stripe errors are logged so that
status 402 errors go to info instead of error. This is meant to signal
that those errors are probably prompted by user data (as opposed to
sending invalid parameters or something), and handling them differently
allows integrations to avoid filling their error logs with messages that
they can't really prevent.
Fixes #869.
r? @ob-stripe
cc @stripe/api-libraries