Bring retry code in-line with current best practices #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brings stripe-go's retry code in-line with what we currently understand to be the best practices as already implemented in stripe-node and stripe-ruby. Basically has the effect of adding some 500s and 503s to results that will be retried.
| if numRetries >= s.MaxNetworkRetries { | ||
| return false | ||
| } | ||
|
|
||
| // TODO: There are many errors that should not be retried. Try to make this | ||
| // more granular by including only connection errors, timeout errors, etc. |
There was a problem hiding this comment.
Added this TODO here because honestly what we're doing right now isn't great.
Unfortunately, routing around Go source looking for errors that we can compare against is slightly non-trivial, so deferring this to a separate improvement project.
|
Thanks! |
|
Released as 62.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings stripe-go's retry code in-line with what we currently understand
to be the best practices as already implemented in stripe-node and
stripe-ruby. Basically has the effect of adding some 500s and 503s to
results that will be retried.
r? @ob-stripe
cc @stripe/api-libraries