Also log error in case of non-stripe.Error
#939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a few cases it's possible for `ResponseToError` to return an error that's not a `*stripe.Error`. This should never happen, but could occur if say the Stripe API returned a mangled JSON blob, but somehow managed to close the connection properly. It's an unlikely scenario, but even so, it's better not to let it slip through the cracks. I also moved one more logging statement out of `ResponseToError` so we can log everything of this type in one place.
ob-stripe
approved these changes
Aug 29, 2019
|
Thank you again :) |
|
Released as 62.8.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few cases it's possible for
ResponseToErrorto return an errorthat's not a
*stripe.Error. This should never happen, but could occurif say the Stripe API returned a mangled JSON blob, but somehow managed
to close the connection properly. It's an unlikely scenario, but even
so, it's better not to let it slip through the cracks.
I also moved one more logging statement out of
ResponseToErrorso wecan log everything of this type in one place.
r? @ob-stripe (Sorry, one more tweak on the last patch.)
cc @stripe/api-libraries