You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From version 23.27.0 and 23.27.1 the size of the StripeApplePay, the size of the binary increases a couples of MB, making the module unusable for App Clips
+------------------------------------------------+
| Swift Package Info |||| StripeApplePay, 23.27.0 |
+--------------+---------------------------------+
| Provider | Results |
+--------------+---------------------------------+
| Binary Size | Binary size increases by 1.2 MB || Platforms | ios from v. 13.0 || Dependencies | No third-party dependencies :) |
+--------------+---------------------------------+
Version 23.27.1
+-----------------------------------------------+
| Swift Package Info |||| StripeApplePay, 23.27.1 |
+--------------+--------------------------------+
| Provider | Results |
+--------------+--------------------------------+
| Binary Size | Binary size increases by 4 MB || Platforms | ios from v. 13.0 || Dependencies | No third-party dependencies :) |
+--------------+--------------------------------+
Note:
Even thou I know that is not an official tool by any sorts, I have used this tool and is consistent with the behavior that I see in the size of the binaries published in Testflight. (Obviously the change is not that drastic, but just 1 more MB can be a detriment to an AppClip).
The text was updated successfully, but these errors were encountered:
Hello, thanks for filing this! It looks like we added some new use of async/await, which caused Xcode to bundle libswift_Concurrency.dylib when an app is targeting iOS 14.0 or earlier. Our framework size scripts were using iOS 14.5, so we missed the size impact of this change. We'll move the offending code, sorry for the trouble!
Out of curiosity, would it be possible to set your App Clip's minimum target OS to 14.5 or later? We may want to use async/await in the future, but we don't want to break any existing users.
## Summary
This contains async/await code, which was causing StripeApplePay to pull
in the Swift Concurrency libraries on iOS 14.0 or earlier. Move it to
StripePaymentSheet, as it isn't used by other frameworks.
## Motivation
#3548
## Testing
`swift-package-info binary-size --local-path . --product StripeApplePay`
## Changelog
Will add
Summary
From version 23.27.0 and 23.27.1 the size of the
StripeApplePay
, the size of the binary increases a couples of MB, making the module unusable for App ClipsCode to reproduce
NONE - Only installing the SDK
iOS version
iOS 17.0 and onwards
Installation method
SPM
SDK version
23.27.1
Other information
Tool that I use to measure:
Swift Package Info
https://github.com/marinofelipe/swift-package-info
And the results are:
Version 23.27.0
Version 23.27.1
Note:
Even thou I know that is not an official tool by any sorts, I have used this tool and is consistent with the behavior that I see in the size of the binaries published in Testflight. (Obviously the change is not that drastic, but just 1 more MB can be a detriment to an AppClip).
The text was updated successfully, but these errors were encountered: