Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DownloadManager to PaymentSheet #3550

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

davidme-stripe
Copy link
Contributor

Summary

This contains async/await code, which was causing StripeApplePay to pull in the Swift Concurrency libraries on iOS 14.0 or earlier. Move it to StripePaymentSheet, as it isn't used by other frameworks.

Motivation

#3548

Testing

swift-package-info binary-size --local-path . --product StripeApplePay

Changelog

Will add

@davidme-stripe
Copy link
Contributor Author

+-----------------------------------------------+
|              Swift Package Info               |
|                                               |
|           StripeApplePay, undefined           |
+-------------+---------------------------------+
| Provider    | Results                         |
+-------------+---------------------------------+
| Binary Size | Binary size increases by 1.2 MB |
+-------------+---------------------------------+
> Total of 1 provider used.

Copy link

emerge-tools bot commented Apr 30, 2024

📸 Snapshot Test

Base build not found

No build was found for the base commit fe67500. This is required to generate a snapshot diff for your pull request.

It's possible that you created a branch off the base commit before all of the CI steps have finished processing, e.g. the one that uploads a build to our system. If that's the case, no problem! Just wait and this will eventually resolve.


🛸 Powered by Emerge Tools

@davidme-stripe davidme-stripe marked this pull request as ready for review April 30, 2024 20:22
@davidme-stripe davidme-stripe requested review from a team as code owners April 30, 2024 20:22
@davidme-stripe davidme-stripe enabled auto-merge (squash) April 30, 2024 20:22
@davidme-stripe davidme-stripe merged commit ad8cf9e into master Apr 30, 2024
3 of 4 checks passed
@davidme-stripe davidme-stripe deleted the davidme/move-downloadmanager branch April 30, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants