STPPaymentCardTextField: changes return key behavior, adds willEndEditingForReturn delegate method #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nil` The type signature says `nonnull`, however it returns `nil` if index+1 is out of bounds. This only happens if the postal code field is on, which most of our testing doesn't cover. Instead, fall through to jump back to the first invalid field. Also add docs to this method for what it returns.
This used to "work" because `nextFirstResponderField` was returning `nil` and first responder wouldn't move. The previous commit necessitated this fix.
This supports 'return' in any field to move to the next. If the STPPaymentCardTextField is completely filled out and valid, and the user was in the last field, resigns first responder instead. Most users only see the return key in non-US countries in the postal code field. We use the on-screen number pad keyboard for the CC number, expiration & CVC. However, with an iPad or a hardware keyboard any field might receive the return key.
…ressed This only notifies the app developer, and does not provide a mechanism to override the behavior that resigns first responder. Also adds a pair of tests.
… text field It already had logic for cycling through the various text fields, but was missing if the user hit the return key (instead of the Next button in our input accessory toolbar). Now that we have the delegate method, use it to move to the first address field too.
csabol-stripe
approved these changes
Jan 10, 2019
yuki-stripe
pushed a commit
that referenced
this pull request
May 3, 2022
* Add ability to mock out responses for snapshot tests * Update comment * renaming variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves behavior when user uses the return key: both for switching between subfields
of the
STPPaymentCardTextField, and to resign first responder when the field is complete.Adds
-[STPPaymentCardTextFieldDelegate paymentCardTextFieldWillEndEditingForReturn:]to let the app developer know when the user hits the return key to leave an
STPPaymentCardTextField.Implementing this new delegate method & calling
becomeFirstResponderon the next fieldin your app's payment form will smoothly move the keyboard focus from the completed
STPPaymentCardTextFieldinto that object you chose.Motivation
Addresses #885 and #314.
Testing
Adds basic unit tests, and I manually tested using both the CardExampleViewController and
our Standard Integration app.
There are several variations of behavior: postal code on/off, validation for US and
non-US, as well as the additional address fields in the
STPAddCardViewController.