Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a shouldReturn or didReturn hook #314

Closed
irace opened this issue Mar 18, 2016 · 3 comments
Closed

Add a shouldReturn or didReturn hook #314

irace opened this issue Mar 18, 2016 · 3 comments

Comments

@irace
Copy link
Contributor

irace commented Mar 18, 2016

When part of a larger form, it’s useful to be able to to move directly to the next field once the credit card field is done being populated.
@jflinter
Copy link

@irace - agreed, but there are a couple of problems with this.

  • The numeric keyboard doesn't have a return key. Inexplicably.
  • You're not always certain a user is done typing. In the annoying case of 3-digit amex CVCs, the user may or may not have a 4th digit to type after typing 3 digits.

I've considered adding a method to STPPaymentCardTextField like automaticallyShowInputAccessoryWithTarget:action: that'll wire up a UIToolbar with a done item as the textField's inputAccessoryView, and auto-enable the done item depending on its internal state. Thoughts?

@irace
Copy link
Contributor Author

irace commented Apr 27, 2016

Not a bad idea, though also probably should be a pretty low priority.

@jflinter
Copy link

Oh, don't worry, it is.

@danj-stripe danj-stripe mentioned this issue Jan 3, 2019
Merged
yuki-stripe pushed a commit that referenced this issue Oct 8, 2021
@mludowise-stripe
IDPROD-2264: Update scripts for modules.yaml (#314)
b614010 
Updates a number of our scripts to use `modules.yaml` for all module-related configurations rather than modifying constants contained in each script.

- Migrates `export_builds.sh` -> `export_builds.rb` and uses modules.yaml to configure `scheme` and `framework_name`
- Updates localization scripts to use modules.yaml's `localization_dir` property
- Updates `pod_tools.rb` to use `pod_push_order` from modules.yaml
- Fixed mistake in `pod_tools.rb` usage text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@irace @jflinter