Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples #1363

Merged
merged 13 commits into from Sep 13, 2019
Merged

Update examples #1363

merged 13 commits into from Sep 13, 2019

Conversation

yuki-stripe
Copy link
Collaborator

@yuki-stripe yuki-stripe commented Sep 9, 2019

Summary

  • Move STPPaymentContext to automatic confirmation - this is the default recommendation now.
  • Update example APIs to match updated example backend.

Motivation

Sync examples with what docs recommend stripe/example-mobile-backend#67

Testing

All the Custom Integration Card example flows, Standard Integration.

@davidme-stripe
Copy link
Contributor

davidme-stripe commented Sep 9, 2019

🎉woo, automatic confirmation

We should update the docs to match.

@@ -17,7 +17,7 @@ class StandardIntegrationUITests: XCTestCase {
// UI tests must launch the application that they test. Doing this in setup will make sure it happens for each test method.
let app = XCUIApplication()
let stripePublishableKey = "pk_test_6Q7qTzl8OkUj5K5ArgayVsFD00Sa5AHMj3"
let backendBaseURL = "https://stripe-mobile-test-backend.herokuapp.com/"
let backendBaseURL = "https://stripe-mobile-test-backend-17.herokuapp.com/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, forgot that versioning would be an issues on these tests. This seems to be an okay workaround, but if it gets too toilsome we should figure out something else.

@yuki-stripe yuki-stripe merged commit c26fffa into master Sep 13, 2019
@yuki-stripe yuki-stripe deleted the yuki-update-examples branch September 13, 2019 21:01
ramont-stripe pushed a commit that referenced this pull request Aug 15, 2022
* Make phone optional by default

* upper case county codes

* Only suggest line 1 for auto complete

* Expand address section when auto complete line is tapped if needed

* update snapshots

* update test

* Revert "upper case county codes"

This reverts commit c17b78a6c233089a06574ee7b7029bb2a23bfc31.

* Uppercase country codes in address section element

* Revert "Expand address section when auto complete line is tapped if needed"

This reverts commit c9c47ca34046bcde98911188f9c07fdfcd3a21bc.

* Remove un-needed beginEditing call

* update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants