ApplePayContext handles shipping #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-stripe
requested review from
csabol-stripe,
aliriaz-stripe and
davidme-stripe
yuki-stripe
commented
Apr 28, 2020
| addressParams.postalCode = address.postalCode; | ||
|
|
||
| NSPersonNameComponentsFormatter *formatter = [NSPersonNameComponentsFormatter new]; | ||
| formatter.style = NSPersonNameComponentsFormatterStyleLong; |
There was a problem hiding this comment.
This produces a name like "Dr. Jonathan Maple Appleseed Esq." vs. ...StyleDefault which produces a name like "Jonathan Appleseed".
yuki-stripe
changed the base branch from
yuki/payment-intent-shipping
to
master
yuki-stripe
force-pushed
the
yuki/applepaycontext-shipping
branch
from
e0d5748
to
3a6b986
Compare
yuki-stripe
commented
Apr 30, 2020
| @@ -90,7 +90,7 @@ - (void)pay { | |||
|
|
|||
| #pragma mark - STPApplePayContextDelegate | |||
|
|
|||
| - (void)applePayContext:(STPApplePayContext *)context didCreatePaymentMethod:(__unused STPPaymentMethod *)paymentMethod completion:(STPIntentClientSecretCompletionBlock)completion { | |||
| - (void)applePayContext:(STPApplePayContext *)context didCreatePaymentMethod:(__unused STPPaymentMethod *)paymentMethod paymentInformation:(__unused PKPayment *)paymentInformation completion:(STPIntentClientSecretCompletionBlock)completion { | |||
There was a problem hiding this comment.
Would appreciate scrutiny on this API change!
| @@ -61,6 +66,8 @@ didSelectShippingMethod:(PKShippingMethod *)shippingMethod | |||
| /** | |||
| Called when the user has selected a new shipping address. You should inspect the | |||
| address and must invoke the completion block with an updated array of PKPaymentSummaryItem objects. | |||
|
|
|||
| @note This does not contain full contact information - you can only receive that after the user authorizes payment, in the paymentInformation passed to `applePayContext:didCreatePaymentMethod:paymentInformation:completion:` | |||
There was a problem hiding this comment.
the distinction here isn't really clear to me. Could we enumerate what is available vs what isn't available here in a little more detail?
csabol-stripe
approved these changes
Apr 30, 2020
kgaidis-stripe
added a commit
that referenced
this pull request
Dec 2, 2022
Financial Connections: started client-side-tinting Consent and Data Access View icons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
STPApplePayContextautomatically attaches shipping details to PaymentIntent upon confirmation, and also passes the rawPKPaymentback to the user if they want to collect shipping details themselves.Motivation
https://jira.corp.stripe.com/browse/IOS-1668
Testing
PKPaymentis passed.