Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows non-numeric zip/postal codes to be entered #415

Merged
merged 1 commit into from
Aug 25, 2016

Conversation

zachwick
Copy link
Contributor

Summary

Allows non-numeric ZIP/Postal codes to be entered

Motivation

Because we explicitly were not setting the keypad layout based on phone
number locale, it was ~impossible to enter non-numeric zip/postal codes
into the zip code type fields using the Stripe iOS SDK.

Testing

I verified that this change still compiled, but I'm unsure how to fake locales in the iOS simulator

Because we explicitly were not setting the keypad layout based on phone
number locale, it was ~impossible to enter non-numeric zip/postal codes
into the zip code type fields using the Stripe iOS SDK.
@bdorfman
Copy link

Looks good to me.

For future ref: To change in simulator, you have to actually go into the sim's Settings app and change it as you would on a real phone under General -> Language & Region

@jflinter
Copy link

@zachwick
Copy link
Contributor Author

Thanks for the info guys! TIL

@zachwick zachwick merged commit 3bf0414 into master Aug 25, 2016
@sadlerjw
Copy link

@zachwick shouldn't this be based on the selected country, not on the user's locale? Or at least be lenient in the implementation and always allow alphanumeric entry? In some situations this could put users unable to enter their correct billing information.

@zachwick
Copy link
Contributor Author

@sadlerjw You are probably correct. However, I made my patch consistent with the other locale checking in this method. I believe that there is currently a large development effort in cleaning up the l18n support in the SDK that I imagine will address this. (cc @bdorfman since I think he is spearheading that effort)

@sadlerjw
Copy link

@zachwick thanks!

@bdorfman bdorfman deleted the zwick_non_us_zipcode_keyboard branch August 29, 2016 20:24
davidme-stripe pushed a commit that referenced this pull request Oct 18, 2021
…415)

* Parse unactivated_payment_method_types and hide unactivated PMs in live mode (need to add logs)

* Add warning log

* Update log

* Remove intent test

* Use test mode instead of live mode

* add clarifying comment

* Move filtering to PaymentMethodAvailability

* Remove comment

* fix whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants