Test Java 16 and 17 #1291
Merged
Test Java 16 and 17 #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
force-pushed
the
ob-java-17
branch
2 times, most recently
from
f845624
to
fc54321
Compare
dcr-stripe
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @stripe/api-library-reviewers
Bump Gradle and dependencies, and start testing Java 16 and 17.
Due to https://github.com/google/google-java-format#jdk-16 I had to add some
--add-exportsarguments to the JVM via theorg.gradle.jvmargsvariable ingradle.properties.However Java 1.8 does not support
--add-exports, so what I did is add a conditional step in.github/workflows/ci.ymlto comment out these arguments when testing Java 1.8. It's kinda gross but I could not find a better way to do this.Note that this does mean that running the test suite locally with Java 1.8 will fail unless you go and manually comment out the
--add-exportslines ingradle.properties.