Push Docker image to Docker Hub #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushes the built Docker image to Docker Hub as part of a Travis deploy step. This allows Docker users to access the image more easily. There are a few caveats with this implementation: 1. We're only building `master`. If this ends up being something we use, we should build tagged version images as well. 2. It pushes to `stripemock/stripe-mock` instead of `stripe/stripe-mock` because we're having a little trouble getting the collaboration privileges worked out on Docker Hub's Stripe organization right now. We should change it to `stripe/stripe-mock` when possible. Fixes #49.
brandur-stripe
force-pushed
the
brandur-docker-hub
branch
from
5f62bf7
to
0781111
Compare
|
Alright, let's see if this works ... |
|
Nice! |
brandur-stripe
pushed a commit
that referenced
this pull request
Mar 21, 2018
In #50 I was able to successfully push an image to Docker Hub, but quite a large one -- weighing in at 91 MB, which is pretty heavy for this small program. Here we lean out the final image by switching `Dockerfile` to use a multi-phase build strategy. This creates one image initially based off of a Go image which is used to build the final release program, then creates a second image based on the lightweight Alpine Linux and copies over the release binary. This has the effect of reducing the final image's size from 91 MB to a lean 13.7 MB, which is faster/cheaper for users to pull. A smaller optimization is to add a `.dockerignore` file which prevents us from having to copy a number of extraneous files into the Docker daemon for the initial build. This will help nominally to speed things up. One slight loss is that I've removed testing within the Go image from `.travis.yml` because we no longer have a Go runtime with which to run `go test ./...`. I think this is okay because we're already running tests elsewhere in the Travis build, and it's unlikely that running them in a Docker container is going to surface anything extra. Here's me running the image locally: ``` $ docker run -d --name stripe-mock-container -p 12112:12111 stripemock/stripe-mock bc71abebe5f6d80a9af2d1d53c86777d8c50b2e9a8d4de4a8b25d66c32a5d44b $ docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES bc71abebe5f6 stripemock/stripe-mock "/bin/sh -c /stripe-…" 26 seconds ago Up 28 seconds 0.0.0.0:12112->12111/tcp stripe-mock-container ``` And a successful cURL: ``` $ curl http://localhost:12112 { "error": { "message": "Please authenticate by specifying an `Authorization` header with any valid looking testmode secret API key. For example, `Authorization: Bearer sk_test_123`. Authorization was ''.", "type": "invalid_request_error" } } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushes the built Docker image to Docker Hub as part of a Travis deploy
step. This allows Docker users to access the image more easily.
There are a few caveats with this implementation:
We're only building
master. If this ends up being something we use,we should build tagged version images as well.
It pushes to
stripemock/stripe-mockinstead ofstripe/stripe-mockbecause we're having a little trouble getting the collaboration
privileges worked out on Docker Hub's Stripe organization right now.
We should change it to
stripe/stripe-mockwhen possible.Fixes #49.