Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET and DELETE requests data: body->queryParams #691

Merged
merged 4 commits into from
Sep 9, 2019

Conversation

richardm-stripe
Copy link
Contributor

r? @ob-stripe
cc? @rattrayalex-stripe @remi-stripe

Addresses #690 -- whenever an ApiResource method is called that corresponds to a GET or DELETE, those properties are attached to the end of the path.

I think this should be safe, assuming:

  1. "Path" never already contains a query string.
  2. No users are sending bodies large enough to risk hitting some sort of URL length limit.

I also changed mocha.opts not to bail by default. Rationale: I couldn't find a way to override this from the command-line (but it's easy to add -b if that's what you want), and I prefer not-bailing in cases where I need to make simple changes in many tests.

@richardm-stripe richardm-stripe merged commit ba9e023 into master Sep 9, 2019
@richardm-stripe richardm-stripe deleted the richardm-data-in-queryparams branch September 9, 2019 22:10
@ob-stripe
Copy link
Contributor

Released as 7.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants