Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET requests use request body instead of query parameters #690

Closed
ajbouh opened this issue Sep 6, 2019 · 2 comments
Closed

GET requests use request body instead of query parameters #690

ajbouh opened this issue Sep 6, 2019 · 2 comments

Comments

@ajbouh
Copy link

ajbouh commented Sep 6, 2019

Setting a body for GET requests appears to be a gray area in the HTTP spec.

This can cause many subtle and hard to debug issues. For example, when the request body is not properly submitted to the server, auto pagination logic goes into an infinite loop, since the starting_after parameter is lost/ignored and it will just return the first 10 values over and over again.

A possible fix would be to just append the data to the request path as query parameters. (This appears to be what curl does automatically.)

@ob-stripe
Copy link
Contributor

Thanks for the report @ajbouh. This was already a known issue but we've been ignoring it for too long. We're working on a fix and will release a new version soon.

@ob-stripe
Copy link
Contributor

This was fixed in 7.9.0, courtesy of @richardm-stripe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants