Bump PHP-CS-Fixer and update code #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @richardm-stripe
cc @stripe/api-libraries
Upgrade PHP-CS-Fixer to 2.17.1 and update code to be compliant with changes to the
@PhpCsFixerruleset.This is a prerequisite to start supporting PHP 8, as the previously pinned version (2.16.5) does not support PHP 8.
I recommend reviewing commit by commit. The changes are fairly minor and affect mostly manually written files, with a couple of exceptions:
lib/Account.php: changes to a method defined via an override, so we can simply update the method definition in codegen to be consistentlib/EphemeralKey.php: changes to the order in which traits are listed. I don't think we can easily fix this in codegen, as one trait (Delete) is added automatically and the other (Create) is added via an override. We can likely leave things as-is and just let themake fmtpostprocess step fix things.