Escape unsanitized input in OAuth example #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we run unsanitized input through `htmlspecialchars` before echoing it to screen. Most of these fields will come from our own processes, but because they're taken from `$_GET`, they could potentially contain content set by a malicious user. I think `htmlspecialchars` is the right thing to do here. It just escapes HTML-related characters instead of anything that has an HTML equivalent like `htmlentities` (which is probably overkill here).
|
Thanks OB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we run unsanitized input through
htmlspecialcharsbefore echoingit to screen. Most of these fields will come from our own processes, but
because they're taken from
$_GET, they could potentially containcontent set by a malicious user.
I think
htmlspecialcharsis the right thing to do here. It justescapes HTML-related characters instead of anything that has an HTML
equivalent like
htmlentities(which is probably overkill here).r? @ob-stripe