Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPDoc return types for allSomething() methods #619

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Fix PHPDoc return types for allSomething() methods #619

merged 1 commit into from
Mar 25, 2019

Conversation

ob-stripe
Copy link
Contributor

@ob-stripe ob-stripe commented Mar 25, 2019 •
edited
Loading

r? @remi-stripe
cc @stripe/api-libraries

Fix the return type in PHPDoc for allSomething() methods (i.e. nested resources).

Replaces #618.

@stripe-ci stripe-ci assigned ob-stripe and unassigned remi-stripe Mar 25, 2019
@ob-stripe ob-stripe merged commit 636003e into master Mar 25, 2019
@ob-stripe ob-stripe deleted the ob-phpdoc-fix-all-return-types branch March 25, 2019 20:10
@ob-stripe
Copy link
Contributor Author

Released as 6.31.2.

@ob-stripe ob-stripe mentioned this pull request Mar 25, 2019
Closed
@adri
Copy link

adri commented Mar 25, 2019

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

Assignees

@ob-stripe ob-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ob-stripe @adri @remi-stripe @stripe-ci