Refactors for beta #1212
Merged
Refactors for beta #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
requested review from
a team and
anniel-stripe
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging master into beta today (#1211) @anniel-stripe and I encountered some merge conflicts because
betabranch had some refactoring thatmasterbranch did not.TestHandlerhelper class. Python doesn't like that this begins withTestso in the beta branch this was renamed toMyTestHandler.APIRequestor.request_rawandAPIRequestor.request_raw_async. In the beta branch, a lot of the common logic was factored out. We undid this when resolving the merge conflict, but here is the same factoring out. You can see the full effect in the beta branch.