New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for /v1/topups endpoints #627
Conversation
@@ -38,7 +38,7 @@ Metrics/MethodLength: | |||
# Offense count: 1 | |||
# Configuration parameters: CountComments. | |||
Metrics/ModuleLength: | |||
Max: 304 | |||
Max: 305 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha. Hopefully it wasn't too painful figuring out that you had to do this. RuboCop as a whole is relatively new. We rolled through at one point and killed a bunch of the RuboCop TODOs, but all the slightly harder ones are still left.
LGTM. @jkakar-stripe Here and with other PRs, would you mind just rebasing so that we have one clean commit to bring in? We are trying to do a little bit better on commit hygiene in the open-source repos these days :$ |
d51f3f6
to
0be2268
Compare
@brandur Thanks! I've rebased all the pull requests down to a single commit. Maybe we should make Squash and merge the only option available on these repositories to avoid the need to manual rebasing? |
Could do. I kind of like the manual rebase it tends to produce final commit messages that don't include all the messages from various throwaway commits in them. Definitely a personal preference thing though. |
@brandur Yeah, that's a good point. I did take the rebase opportunity to create a clean commit message for each branch. |
Nice, and looks great. Thanks! |
r? @stripe/api-libraries |
LGTM. |
Released as 3.10.0. |
What are topups? 🤔 They don't appear in the docs yet, although there are some events related to them documented. |
@timrogers It's an upcoming feature that's not documented yet. |
This add standard retrieve, create and update client support for the new
/v1/topups
endpoint.r? @apakulov-stripe @ccontinanza-stripe @chellman-stripe @kenneth-stripe @miguel-stripe
r? @stripe/api-libraries