Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for /v1/topups endpoints #627

Merged
merged 1 commit into from Feb 21, 2018
Merged

Conversation

jkakar-stripe
Copy link
Contributor

This add standard retrieve, create and update client support for the new /v1/topups endpoint.

r? @apakulov-stripe @ccontinanza-stripe @chellman-stripe @kenneth-stripe @miguel-stripe
r? @stripe/api-libraries

@stripe-ci
Copy link

@@ -38,7 +38,7 @@ Metrics/MethodLength:
# Offense count: 1
# Configuration parameters: CountComments.
Metrics/ModuleLength:
Max: 304
Max: 305
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha. Hopefully it wasn't too painful figuring out that you had to do this. RuboCop as a whole is relatively new. We rolled through at one point and killed a bunch of the RuboCop TODOs, but all the slightly harder ones are still left.

@brandur-stripe
Copy link
Contributor

LGTM.

@jkakar-stripe Here and with other PRs, would you mind just rebasing so that we have one clean commit to bring in? We are trying to do a little bit better on commit hygiene in the open-source repos these days :$

@jkakar-stripe
Copy link
Contributor Author

@brandur Thanks! I've rebased all the pull requests down to a single commit. Maybe we should make Squash and merge the only option available on these repositories to avoid the need to manual rebasing?

@brandur-stripe
Copy link
Contributor

@brandur Thanks! I've rebased all the pull requests down to a single commit. Maybe we should make Squash and merge the only option available on these repositories to avoid the need to manual rebasing?

Could do. I kind of like the manual rebase it tends to produce final commit messages that don't include all the messages from various throwaway commits in them. Definitely a personal preference thing though.

@jkakar-stripe
Copy link
Contributor Author

@brandur Yeah, that's a good point. I did take the rebase opportunity to create a clean commit message for each branch.

@brandur-stripe
Copy link
Contributor

Yeah, that's a good point. I did take the rebase opportunity to create a clean commit message for each branch.

Nice, and looks great. Thanks!

@apakulov-stripe
Copy link

r? @stripe/api-libraries

@brandur-stripe
Copy link
Contributor

LGTM.

@brandur-stripe brandur-stripe merged commit 529b9ec into master Feb 21, 2018
@brandur-stripe brandur-stripe deleted the jkakar/topup-client branch February 21, 2018 19:35
@brandur-stripe
Copy link
Contributor

Released as 3.10.0.

@timrogers
Copy link

What are topups? 🤔 They don't appear in the docs yet, although there are some events related to them documented.

@ob-stripe
Copy link
Contributor

@timrogers It's an upcoming feature that's not documented yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants