Override StripeObject#eql? and #hash to produce more optimistic equivalency
#688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quivalency Overrides `#eql?` (hash equality) and `#hash` so that Stripe objects can be used more easily as Hash keys and that certain other frameworks that rely on these methods will have an easier time (e.g. RSpec's `change`, see #687). I think this might be a little controversial if we weren't already overriding the `#==` implementation, but because we are, I think it makes sense to extent it to these two methods as well.
brandur-stripe
force-pushed
the
brandur-hash
branch
from
8a4dfce
to
7c01836
Compare
|
Released as 3.26.1. |
|
Thanks OB! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overrides
#eql?(hash equality) and#hashso that Stripe objects canbe used more easily as Hash keys and that certain other frameworks that
rely on these methods will have an easier time (e.g. RSpec's
change,see #687).
I think this might be a little controversial if we weren't already
overriding the
#==implementation, but because we are, I think itmakes sense to extend it to these two methods as well.
Fixes #687.
r? @ob-stripe