Making stripe telemetry more specific in terms of units #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also truncate the |
|
@brandur yeah, that works for me, especially since other languages will probably not have this metric as a float |
akropp-stripe
force-pushed
the
akropp-telemetry-in-ms
branch
from
fa873c7
to
b900b16
Compare
|
r? @brandur-stripe updated |
|
@devshorts LGTM! Lint's failing because the newline introduced on 223 has leading indentation in it. Do you want to just take that whole line out and re-push? Thanks! ptal @devshorts |
akropp-stripe
force-pushed
the
akropp-telemetry-in-ms
branch
from
b900b16
to
5e3c3a9
Compare
|
@brandur-stripe totes! thanks! pushed up |
|
Released as 3.31.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #696 making a minor change to make the telemetry payload more specific in terms of timing units. I'm making the payload specific that it is in milliseconds and enforcing that in the ruby time difference. This is important so we can keep cross binding payloads consistent.
r? @ob-stripe @brandur-stripe