Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in Interval in the s3 plugin from int to float64 #759

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

linuxdynasty
Copy link
Contributor

@linuxdynasty linuxdynasty commented Sep 30, 2019

  • Currently all counters return a +Inf and this is due to the fact that we are
    not passing Interval in server.go. Also in s3.go, interval was set to int instead
    of float64.
  • Update csv_test.go to include tests when passing an Interval of 0.

Summary

As of right now any samplers.CounterMetric has a divide by 0 error which reports back as +Inf. This PR will fix that error for the S3 Plugin and the Localfile plugin. I also updated the tests in csv_test.go and s3_tests.go to check for +Inf.

Motivation

Counters were producing +Inf

Test plan

I updated tests in csv_test.go and s3_tests.go

Rollout/monitoring/revert plan


This change is Reviewable

* Currently all counters return a +Inf and this is due to the fact that we are
not passing Interval in server.go. Also in s3.go, interval was set to int instead
of float64.
* Update csv_test.go to include tests when passing an Interval of 0.
@stripe-ci
Copy link

Gerald Rule: Copy Observability on Veneur, Unilog, Falconer pull requests

cc @stripe/observability
@stripe/observability-stripe

@linuxdynasty
Copy link
Contributor Author

Is there anything further that the stripe team needs me to do for this PR request? I have the other PR #758 for updating how AWS credentials are handled and I will have 2 more PR requests that depend on these 2 being merged in.

@linuxdynasty
Copy link
Contributor Author

I am using Veneur plugins heavily and I would rather not host a local version of Veneur for too long. Could someone let me know if this PR is missing something? As of right now, the S3 plugin is not working without this fix.

@CLAassistant
Copy link

CLAassistant commented Aug 6, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ linuxdynasty
❌ Allen Sanabria


Allen Sanabria seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants