Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ci-friendly versions for mvn-based packages #31

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Configure ci-friendly versions for mvn-based packages #31

merged 1 commit into from
Nov 7, 2020

Conversation

j4ckofalltrades
Copy link
Contributor

@j4ckofalltrades j4ckofalltrades commented Oct 30, 2020

Append PACKAGE_REVISION (timestamp in yyyyMMdd-HHmm format) to generated package version. This should be applied to all mvn-based packages.

Generated package: https://github.com/j4ckofalltrades/strongbox-examples/packages/472460

Refs strongbox/strongbox#1927

@j4ckofalltrades
Copy link
Contributor Author

@carlspring Requesting review

Copy link
Member

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! :)

@carlspring
Copy link
Member

@steve-todorov : Could you please have a look as well? If you're happy with it, let's merge it.

@steve-todorov steve-todorov merged commit 04362f7 into strongbox:master Nov 7, 2020
@j4ckofalltrades j4ckofalltrades deleted the issue-1927-mvn-based-pkg-ci-friendly branch November 8, 2020 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants