Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup deployment to GitHub package registry for ant-ivy artifacts #32

Merged
merged 2 commits into from
Nov 7, 2020
Merged

Setup deployment to GitHub package registry for ant-ivy artifacts #32

merged 2 commits into from
Nov 7, 2020

Conversation

j4ckofalltrades
Copy link
Contributor

@j4ckofalltrades j4ckofalltrades commented Oct 30, 2020

Includes changes in #31
Refs strongbox/strongbox#1927

@j4ckofalltrades
Copy link
Contributor Author

@carlspring Requesting review

@carlspring
Copy link
Member

@steve-todorov : Could you please have a look as well? If you're happy with it, let's merge it.

Copy link
Member

@steve-todorov steve-todorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@steve-todorov
Copy link
Member

By the way, I was thinking - do you, perhaps, know how to limit the jobs to build only when a file from the respective example directory was changed? It would make more sense for those to be built only upon changes and will definitely make it easier for deploying since you wouldn't need to change all versions in all examples (referring to the forbidden version deletion and re-deployment issues which will occur if you re-deploy the same version)

@j4ckofalltrades
Copy link
Contributor Author

do you, perhaps, know how to limit the jobs to build only when a file from the respective example directory was changed?

I'm afraid there is no out-of-box way to do this (at least from what I've read from the Github Actions docs).

@steve-todorov steve-todorov merged commit 65868d7 into strongbox:master Nov 7, 2020
@j4ckofalltrades j4ckofalltrades deleted the issue-1927-ant-ivy branch November 9, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants