Upgrade to lodash 3.x #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,7 @@ var vm = require('vm'); | |||
|
|
|||
| describe('browser support', function() { | |||
| this.timeout(60000); // 60s to give browserify enough time to finish | |||
| sandbox.reset(); | |||
There was a problem hiding this comment.
This is wrong. It should be either before(sandbox.reset) or beforeEach(sandbox.reset). I think beforeEach makes more sense.
There was a problem hiding this comment.
Yep, that's clearly wrong. I blame tap.
|
Releasing this fix will be tricky, as npmjs.org displays README from the last published version. After we release 1.x, we must release another 2.x version to get the right README displayed. |
|
@bajtos I fixed the |
|
Regarding a release, it looks like there are a couple unreleased changes on master.. if you do a 1.x release just before releasing them that would be awesome :-) |
|
Nevermind, my repo was out of date.. you released from master 8 hours ago. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace single-function module with full lodash, which can be shared with other packages if installed in a parent module.
See strongloop/strongloop#213 for context. This is an interim solution so that loopback-workspace can benefit from this change without having to upgrade to loopback-boot 2.x.