fix(repository-tests): disconnect datasources after tests finish

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
loopbackio · Aug 11, 2020 · c574303 · c574303
1 parent b7cf13f
commit c574303
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/packages/repository-tests/src/crud-test-suite.ts b/packages/repository-tests/src/crud-test-suite.ts
@@ -48,9 +48,16 @@ export function crudRepositoryTestSuite(
     );
     before(
       withCrudCtx(function setupGlobalDataSource(ctx: CrudTestContext) {
+        debug('Initializing the shared datasource instance.');
         ctx.dataSource = new juggler.DataSource(ctx.dataSourceOptions);
       }),
     );
+    after(
+      withCrudCtx(function destroyGlobalDataSource(ctx: CrudTestContext) {
+        debug('Disconnecting the shared datasource instance.');
+        return ctx.dataSource.disconnect();
+      }),
+    );
 
     let testFiles = [];
 

diff --git a/packages/repository-tests/src/crud/transactions.suite.ts b/packages/repository-tests/src/crud/transactions.suite.ts
@@ -60,6 +60,8 @@ export function transactionSuite(
         >;
         let tx: Transaction | undefined;
         let ds: juggler.DataSource;
+        let ds2: juggler.DataSource;
+
         before(
           withCrudCtx(async function setupRepository(ctx: CrudTestContext) {
             ds = ctx.dataSource;
@@ -85,6 +87,13 @@ export function transactionSuite(
           }
         });
 
+        afterEach(async () => {
+          if (ds2) {
+            ds2.disconnect();
+            (ds2 as unknown) = undefined;
+          }
+        });
+
         it('retrieves model instance once transaction is committed', async () => {
           tx = await repo.beginTransaction(IsolationLevel.READ_COMMITTED);
           const created = await repo.create(
@@ -149,7 +158,7 @@ export function transactionSuite(
           const ds2Options = Object.assign({}, dataSourceOptions);
           ds2Options.name = 'anotherDataSource';
           ds2Options.database = ds2Options.database + '_new';
-          const ds2 = new juggler.DataSource(ds2Options);
+          ds2 = new juggler.DataSource(ds2Options);
           const anotherRepo = new repositoryClass(Product, ds2);
           await ds2.automigrate(Product.name);