Skip to content

Commit

Permalink
feat: move framework packages to peerDependencies
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Extensions no longer install framework packages as
their own dependencies, they use the framework packages provided by the
target application instead.

If you are getting `npm install` errors after upgrade, then make sure
your project lists all dependencies required by the extensions you are
using.

Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
  • Loading branch information
bajtos committed Sep 4, 2020
1 parent 0cb85fc commit d8f72e4
Show file tree
Hide file tree
Showing 10 changed files with 65 additions and 24 deletions.
8 changes: 6 additions & 2 deletions extensions/apiconnect/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,18 @@
"url": "https://github.com/strongloop/loopback-next.git",
"directory": "extensions/apiconnect"
},
"dependencies": {
"peerDependencies": {
"@loopback/core": "^2.9.5",
"@loopback/rest": "^6.2.0",
"@loopback/rest": "^6.2.0"
},
"dependencies": {
"tslib": "^2.0.1"
},
"devDependencies": {
"@loopback/build": "^6.2.2",
"@loopback/core": "^2.9.5",
"@loopback/eslint-config": "^9.0.2",
"@loopback/rest": "^6.2.0",
"@loopback/testlab": "^3.2.4",
"@types/node": "^10.17.29"
}
Expand Down
11 changes: 8 additions & 3 deletions extensions/authentication-jwt/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,27 @@
"publishConfig": {
"access": "public"
},
"dependencies": {
"peerDependencies": {
"@loopback/authentication": "^6.0.1",
"@loopback/core": "^2.9.5",
"@loopback/rest": "^6.2.0",
"@loopback/rest": "^6.2.0"
},
"dependencies": {
"@loopback/security": "^0.2.18",
"@loopback/service-proxy": "^2.3.8",
"@types/bcryptjs": "2.4.2",
"bcryptjs": "^2.4.3",
"jsonwebtoken": "^8.5.1"
},
"devDependencies": {
"@loopback/authentication": "^6.0.1",
"@loopback/boot": "^2.5.1",
"@loopback/build": "^6.2.2",
"@loopback/core": "^2.9.5",
"@loopback/eslint-config": "^9.0.2",
"@loopback/repository": "^2.11.2",
"@loopback/rest": "^6.2.0",
"@loopback/rest-explorer": "^2.2.10",
"@loopback/service-proxy": "^2.3.8",
"@loopback/testlab": "^2.0.2",
"@types/lodash": "^4.14.161",
"@types/node": "^10.17.29",
Expand Down
9 changes: 7 additions & 2 deletions extensions/authentication-passport/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,20 +39,25 @@
"url": "https://github.com/strongloop/loopback-next.git",
"directory": "extensions/authentication-passport"
},
"dependencies": {
"peerDependencies": {
"@loopback/authentication": "^6.0.1",
"@loopback/core": "^2.9.5",
"@loopback/rest": "^6.2.0",
"@loopback/rest": "^6.2.0"
},
"dependencies": {
"@loopback/security": "^0.2.18",
"passport": "^0.4.1",
"tslib": "^2.0.1",
"util-promisifyall": "^1.0.6"
},
"devDependencies": {
"@loopback/authentication": "^6.0.1",
"@loopback/build": "^6.2.2",
"@loopback/core": "^2.9.5",
"@loopback/eslint-config": "^9.0.2",
"@loopback/mock-oauth2-provider": "^0.1.7",
"@loopback/openapi-spec-builder": "^2.1.13",
"@loopback/rest": "^6.2.0",
"@loopback/testlab": "^3.2.4",
"@types/jsonwebtoken": "^8.5.0",
"@types/lodash": "^4.14.161",
Expand Down
8 changes: 6 additions & 2 deletions extensions/context-explorer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,19 @@
"publishConfig": {
"access": "public"
},
"dependencies": {
"peerDependencies": {
"@loopback/core": "^2.9.5",
"@loopback/rest": "^6.2.0",
"@loopback/rest": "^6.2.0"
},
"dependencies": {
"ts-graphviz": "^0.13.2",
"viz.js": "^2.1.2"
},
"devDependencies": {
"@loopback/build": "^6.2.2",
"@loopback/core": "^2.9.5",
"@loopback/eslint-config": "^9.0.2",
"@loopback/rest": "^6.2.0",
"@loopback/testlab": "^3.2.4",
"@types/node": "^10.17.29"
},
Expand Down
5 changes: 4 additions & 1 deletion extensions/cron/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"access": "public"
},
"dependencies": {
"@loopback/core": "^2.9.5",
"@types/cron": "^1.7.2",
"@types/debug": "^4.1.5",
"cron": "^1.8.2",
Expand All @@ -30,6 +29,7 @@
},
"devDependencies": {
"@loopback/build": "^6.2.2",
"@loopback/core": "^2.9.5",
"@loopback/eslint-config": "^9.0.2",
"@loopback/testlab": "^3.2.4",
"@types/node": "^10.17.29"
Expand All @@ -49,5 +49,8 @@
"type": "git",
"url": "https://github.com/strongloop/loopback-next.git",
"directory": "extensions/cron"
},
"peerDependencies": {
"@loopback/core": "^2.9.5"
}
}
8 changes: 6 additions & 2 deletions extensions/health/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,19 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@loopback/core": "^2.9.5",
"@loopback/rest": "^6.2.0"
},
"dependencies": {
"@cloudnative/health": "^2.1.2",
"@loopback/core": "^2.9.5",
"@loopback/rest": "^6.2.0",
"tslib": "^2.0.1"
},
"devDependencies": {
"@loopback/build": "^6.2.2",
"@loopback/core": "^2.9.5",
"@loopback/eslint-config": "^9.0.2",
"@loopback/rest": "^6.2.0",
"@loopback/testlab": "^3.2.4",
"@types/node": "^10.17.29"
},
Expand Down
8 changes: 6 additions & 2 deletions extensions/logging/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,11 @@
"publishConfig": {
"access": "public"
},
"dependencies": {
"peerDependencies": {
"@loopback/core": "^2.9.5",
"@loopback/rest": "^6.2.0",
"@loopback/rest": "^6.2.0"
},
"dependencies": {
"fluent-logger": "^3.4.1",
"morgan": "^1.10.0",
"tslib": "^2.0.1",
Expand All @@ -31,7 +33,9 @@
},
"devDependencies": {
"@loopback/build": "^6.2.2",
"@loopback/core": "^2.9.5",
"@loopback/eslint-config": "^9.0.2",
"@loopback/rest": "^6.2.0",
"@loopback/testlab": "^3.2.4",
"@types/morgan": "^1.9.1",
"@types/node": "^10.17.29"
Expand Down
8 changes: 6 additions & 2 deletions extensions/metrics/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,19 @@
"publishConfig": {
"access": "public"
},
"dependencies": {
"peerDependencies": {
"@loopback/core": "^2.9.5",
"@loopback/rest": "^6.2.0",
"@loopback/rest": "^6.2.0"
},
"dependencies": {
"prom-client": "^12.0.0",
"tslib": "^2.0.1"
},
"devDependencies": {
"@loopback/build": "^6.2.2",
"@loopback/core": "^2.9.5",
"@loopback/eslint-config": "^9.0.2",
"@loopback/rest": "^6.2.0",
"@loopback/testlab": "^3.2.4",
"@types/express": "^4.17.8",
"@types/node": "^10.17.29",
Expand Down
5 changes: 4 additions & 1 deletion extensions/pooling/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,17 @@
"src",
"!*/__tests__"
],
"peerDependencies": {
"@loopback/core": "^2.9.5"
},
"dependencies": {
"@loopback/core": "^2.9.5",
"@types/generic-pool": "^3.1.9",
"generic-pool": "^3.7.1",
"tslib": "^2.0.1"
},
"devDependencies": {
"@loopback/build": "^6.2.2",
"@loopback/core": "^2.9.5",
"@loopback/testlab": "^3.2.4",
"@types/node": "^10.17.29",
"typescript": "~4.0.2"
Expand Down
19 changes: 12 additions & 7 deletions extensions/typeorm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,27 @@
"publishConfig": {
"access": "public"
},
"peerDependencies": {
"@loopback/boot": "^2.5.1",
"@loopback/core": "^2.9.5",
"@loopback/rest": "^6.2.0"
},
"dependencies": {
"tslib": "^2.0.1",
"typeorm": "^0.2.25"
},
"devDependencies": {
"@loopback/boot": "^2.5.1",
"@loopback/build": "^5.4.3",
"@loopback/core": "^2.9.5",
"@loopback/eslint-config": "^9.0.2",
"@loopback/repository": "^2.11.2",
"@loopback/rest": "^6.2.0",
"@loopback/testlab": "^3.2.4",
"@types/json-schema": "^7.0.6",
"@types/node": "^10.17.29",
"sqlite3": "^5.0.0"
},
"dependencies": {
"@loopback/boot": "^2.5.1",
"@loopback/core": "^2.9.5",
"@loopback/rest": "^6.2.0",
"tslib": "^2.0.1",
"typeorm": "^0.2.25"
},
"files": [
"README.md",
"dist",
Expand Down

0 comments on commit d8f72e4

Please sign in to comment.