Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut tests for @param #1052

Closed
3 tasks
jannyHou opened this issue Feb 26, 2018 · 4 comments
Closed
3 tasks

Add shortcut tests for @param #1052

jannyHou opened this issue Feb 26, 2018 · 4 comments
Assignees
Labels
needs grooming REST Issues related to @loopback/rest package and REST transport in general tech-debt
Milestone

Comments

@jannyHou
Copy link
Contributor

jannyHou commented Feb 26, 2018

Add shortcut tests for
@param.query.*
@param.header.*
@param.path.*

Take shortcuts @param.header.* as an example, the current test cases can be found in https://github.com/strongloop/loopback-next/blob/master/packages/openapi-v3/test/unit/decorators/param/param-path.decorator.unit.ts

The missing ones are:

  • @param.path.long
  • float
  • double
  • byte
  • binary
  • date
  • datetime
  • password

And add the same missing tests for @param.query.* and @param.path.*

Acceptance Criteria:

  • Add missing shortcut test case for @param.header.*
  • Add missing shortcut test case for @param.query.*
  • Add missing shortcut test case for @param.path.*
@jannyHou jannyHou added the REST Issues related to @loopback/rest package and REST transport in general label Feb 26, 2018
@jannyHou jannyHou mentioned this issue Feb 26, 2018
6 tasks
@shimks
Copy link
Contributor

shimks commented Feb 27, 2018

Tagging this with #753

@shimks
Copy link
Contributor

shimks commented Apr 30, 2018

@jannyHou Could you update the issue with an appropriate acceptance criteria? Thanks

@jannyHou
Copy link
Contributor Author

jannyHou commented May 2, 2018

@shimks Updated :)

@jannyHou
Copy link
Contributor Author

PR merged

@shimks shimks added this to the May Milestone milestone May 22, 2018
@bajtos bajtos added the p1 label Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs grooming REST Issues related to @loopback/rest package and REST transport in general tech-debt
Projects
None yet
Development

No branches or pull requests

4 participants