fix(cli): tweaks to templates #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
reviewed
Aug 20, 2018
| @@ -20,7 +20,7 @@ | |||
| "clean": "lb-clean dist*", | |||
| <% if (project.prettier && project.tslint) { -%> | |||
| "lint": "npm run prettier:check && npm run tslint", | |||
| "lint:fix": "npm run prettier:fix && npm run tslint:fix", | |||
| "lint:fix": "npm run tslint:fix && npm run prettier:fix", | |||
There was a problem hiding this comment.
Do you want to fix loopback-next/package.json as well?
|
@virkt25 Please fix the test failures. |
- Move `ping.controller.acceptance.ts` from `/test` to `/test/acceptance`. - For REST Controller Template change `obj` to the model name as it's more descriptive - Remove unused import from datasource template - Run `tslint:fix` before `prettire:fix` for `lint:fix` since I ran into an issue where tslint:fix breaks prettier formatting requiring you to run `prettier:fix` / `lint:fix` again. - Reorder the dependencies so they are alphabetical otherwise `npm install` results in additional changes to the file diff ass it reorders the deps alphabetically.
|
@raymondfeng Fixed. PTAL. |
raymondfeng
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across the following annoyances when working on
@loopback/example-shoppingping.controller.acceptance.tsfrom/testto/test/acceptance.objto the model name as it's more descriptivetslint:fixbeforeprettire:fixforlint:fixsince I ran into an issue where tslint:fix breaks prettier formatting requiring you to runprettier:fix/lint:fixagain.npm installresults in additional changes to the file diff ass it reorders the deps alphabetically.Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated