Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow LB4 app with lifecycle observers to be mounted to Express #3879

Merged
merged 2 commits into from Oct 7, 2019
Merged

feat: allow LB4 app with lifecycle observers to be mounted to Express #3879

merged 2 commits into from Oct 7, 2019

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Oct 5, 2019 •
edited

Fixes #3878

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

agnes512
agnes512 approved these changes Oct 5, 2019
View reviewed changes
Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bajtos
bajtos suggested changes Oct 7, 2019
View reviewed changes
examples/express-composition/index.js Outdated Show resolved Hide resolved
@dhmlau dhmlau mentioned this pull request Oct 7, 2019
Closed
@raymondfeng
feat(rest): add listenOnStart flag to control http listening for a re…
7645a69 
…st server

The REST server can be mounted as a route for a facade Express application.
In such cases, we need to tell the REST server not to listen during start().
@raymondfeng raymondfeng merged commit 8d3401d into master Oct 7, 2019
@raymondfeng raymondfeng deleted the express-lifecycle branch October 7, 2019 17:42
@raymondfeng raymondfeng mentioned this pull request Oct 7, 2019
Merged
7 tasks
@JamilOmar
Copy link

@raymondfeng do you have an aproximated date for the package deployment at npm ??

@raymondfeng
Copy link
Contributor Author

@JamilOmar We can publish a release once #3891 is landed.

@JamilOmar
Copy link

@raymondfeng thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos requested changes

@jannyHou jannyHou jannyHou approved these changes

@nabdelgadir nabdelgadir nabdelgadir approved these changes

@agnes512 agnes512 agnes512 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lifeCycleObserver is not working with express composition
6 participants
@raymondfeng @JamilOmar @bajtos @jannyHou @nabdelgadir @agnes512