Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow LB4 app with lifecycle observers to be mounted to Express #3879

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@raymondfeng
Copy link
Member

raymondfeng commented Oct 5, 2019

Fixes #3878

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@raymondfeng raymondfeng requested review from bajtos and nabdelgadir as code owners Oct 5, 2019
Copy link
Contributor

agnes512 left a comment

LGTM

examples/express-composition/index.js Outdated Show resolved Hide resolved
鈥t server

The REST server can be mounted as a route for a facade Express application.
In such cases, we need to tell the REST server not to listen during start().
@raymondfeng raymondfeng force-pushed the express-lifecycle branch from 170df8e to 2fd0dd8 Oct 7, 2019
@raymondfeng raymondfeng force-pushed the express-lifecycle branch from 2fd0dd8 to a07a0c5 Oct 7, 2019
@raymondfeng raymondfeng merged commit 8d3401d into master Oct 7, 2019
4 checks passed
4 checks passed
Travis CI - Pull Request Build Passed
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage increased (+0.01%) to 91.831%
Details
@raymondfeng raymondfeng deleted the express-lifecycle branch Oct 7, 2019
@raymondfeng raymondfeng mentioned this pull request Oct 7, 2019
2 of 7 tasks complete
@JamilOmar

This comment has been minimized.

Copy link

JamilOmar commented Oct 7, 2019

@raymondfeng do you have an aproximated date for the package deployment at npm ??

@raymondfeng

This comment has been minimized.

Copy link
Member Author

raymondfeng commented Oct 7, 2019

@JamilOmar We can publish a release once #3891 is landed.

@JamilOmar

This comment has been minimized.

Copy link

JamilOmar commented Oct 7, 2019

@raymondfeng thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can鈥檛 perform that action at this time.