Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #94 - adds a bit more text to filter #3213

Closed
wants to merge 0 commits into from

Conversation

cfjedimaster
Copy link

@cfjedimaster cfjedimaster commented Feb 20, 2017

Description

Addresses #94

Adds a bit more description to the filter text fields to make it more obvious what is expected there.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

No new tests were written as this just modified a label - if that is wrong, let me know.

@bajtos bajtos self-assigned this Feb 20, 2017
@bajtos
Copy link
Member

bajtos commented Feb 20, 2017

Hey @cfjedimaster, thank you for the pull request! I'll take a look and review it in the next few days.

@bajtos bajtos self-requested a review February 20, 2017 16:39
@bajtos
Copy link
Member

bajtos commented Feb 20, 2017

@cfjedimaster for starter, please make sure npm test passes on your machine. Some of the lines are too long now - see e.g. https://travis-ci.org/strongloop/loopback/jobs/203503716#L596.

@cfjedimaster
Copy link
Author

Ugh - I apologize - I honestly thought this was a tiny string change.

@bajtos
Copy link
Member

bajtos commented Feb 21, 2017

@cfjedimaster sorry for closing the pull request. I wanted to squash the commit history for you, unfortunately when a pull request is opened from the master branch, github closes it after git push -f :(

I opened a new pull request to land the change - see #3218

BTW #94 is a very old pull request that don't seem to be related to this change. Did you perhaps want to refer to issue 94 in a different repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants