Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update deps + fix linting + .npmrc #3963

Merged
merged 1 commit into from
Aug 8, 2018
Merged

chore: update deps + fix linting + .npmrc #3963

merged 1 commit into from
Aug 8, 2018

Conversation

virkt25
Copy link
Contributor

@virkt25 virkt25 commented Aug 8, 2018

Description

  • Upgrade some of our Dev Dependencies
  • Fix Linting to match latest style guide
  • Add .npmrc to disable package-lock.json

Related issues

  • connect to <link_to_referenced_issue>

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@virkt25 virkt25 self-assigned this Aug 8, 2018
@virkt25
Copy link
Contributor Author

virkt25 commented Aug 8, 2018

passport, push, storage, remote downstream are failing because of linting errors in those repos. soap and angular-cli seem like test failures but unrelated to this PR. Same for other downstream examples / bluemix related stuff.

@virkt25 virkt25 merged commit 5ee731e into master Aug 8, 2018
@virkt25 virkt25 deleted the fix-lint branch August 8, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shimks shimks shimks approved these changes

@bajtos bajtos Awaiting requested review from bajtos

@clark0x clark0x Awaiting requested review from clark0x

@ebarault ebarault Awaiting requested review from ebarault ebarault is a code owner

@fabien fabien Awaiting requested review from fabien fabien is a code owner

@zbarbuto zbarbuto Awaiting requested review from zbarbuto zbarbuto is a code owner

Assignees

@virkt25 virkt25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@virkt25 @shimks