feat: change hasone relation error message

[sujeshthekkepatt]

The current hasone error message is not appropriate one.
So adds a better message.
See more #4278

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

• npm test passes on your machine
• New tests added or existing tests modified to cover all changes
• Code conforms with the style guide
• Commit messages are following our guidelines

[slnode]

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

[sujeshthekkepatt]

Sorry for the closed PR's some misunderstanding occurred.

[bajtos]

Thank you @sujeshthekkepatt for the pull request.

It looks like you have reformatted all code in the two files you are modified, this makes it pretty much impossible to review the changes. Please revert the formatting changes and modify only the relevant lines.

I am guessing that your editor/IDE is configured to automatically format the code on save, maybe using Prettier? You should disable that feature while working in LoopBack 3 codebase.

Also please keep all work in this pull request, DO NOT open a new one. We can help you to clean the git commit history once the changes look good.

You can run git revert HEAD or git revert -n HEAD to undo the formatting changes.

[sujeshthekkepatt]

@bajtos thanks for the review. Sorry for the formatting problem. I will modify accordingly. I got a confusion on the linter and prettier. That's what happened.

[sujeshthekkepatt]

@bajtos seems there is a commit linter issue. Can you check the code now?

[dhmlau]

@sujeshthekkepatt, the commit linter error is:

**************************************************
**
**  Linting commit logs
**
**  1 problems found:
**    ec1d4ce - Revert "feat: change hasone relation error message": First line should be 50 characters or less (saw 51)
**
**************************************************

For details, please refer to our commit message guideline. Thanks! https://loopback.io/doc/en/contrib/git-commit-messages.html

[sujeshthekkepatt]

@dhmlau yeah got that. I was hoping to do a squash after the code review. I will update accordingly. @dhmlau done that .

[sujeshthekkepatt]

@bajtos any updates?

[dhmlau]

@sujeshthekkepatt, thanks for your PR. LGTM. I'd like to get at least one more reviews from the maintainers before landing.
@strongloop/loopback-maintainers, could you please review? Thanks!

[agnes512]

LGTM

[dhmlau]

@agnes512, thanks for reviewing.
I'm landing this PR because I saw @bajtos' comments have been addressed.

[dhmlau]

@sujeshthekkepatt, thanks for your contribution. Your PR has landed! 🎉