-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint and test on Node.js 0.12.x and io.js 1.6.x #66
Conversation
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
I think it would be easier to merge for maintainer if the linting was not done in the same PR. |
@slnode ok to test |
@e-jigsaw that's a lot of work cleaning up this mess, thanks for all your effort. It's still not quite the preferred style, but it's consistent and infinitely better than the mishmash that was there 👍 @seriousben in this case all that was meant by "adding support" was adding them to the travis config, so it's pretty minor. |
Lint and test on Node.js 0.12.x and io.js 1.6.x
@rmg thanks 👍 |
Hi,
This PR contains two features.
I wanted to add new
restart
feature. But, to read a code is hard for me. So I add jshint in first. Then I was refactoring a code based on the jshint's warning and error. After that, I noticed Node.js 0.12.x and io.js do not tested in travis when I tested a codes. So I edited.travis.yml
.Thanks