Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint and test on Node.js 0.12.x and io.js 1.6.x #66

Merged
merged 15 commits into from
Apr 1, 2015

Conversation

e-jigsaw
Copy link
Contributor

@e-jigsaw e-jigsaw commented Apr 1, 2015

Hi,

This PR contains two features.

  • Add jshint
  • Add test for Node.js 0.12.x and io.js 1.6.x in travis

I wanted to add new restart feature. But, to read a code is hard for me. So I add jshint in first. Then I was refactoring a code based on the jshint's warning and error. After that, I noticed Node.js 0.12.x and io.js do not tested in travis when I tested a codes. So I edited .travis.yml.

Thanks

@slnode
Copy link

slnode commented Apr 1, 2015

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@seriousben
Copy link

I think it would be easier to merge for maintainer if the linting was not done in the same PR.

@rmg
Copy link
Member

rmg commented Apr 1, 2015

@slnode ok to test

@rmg
Copy link
Member

rmg commented Apr 1, 2015

@e-jigsaw that's a lot of work cleaning up this mess, thanks for all your effort. It's still not quite the preferred style, but it's consistent and infinitely better than the mishmash that was there 👍

@seriousben in this case all that was meant by "adding support" was adding them to the travis config, so it's pretty minor.

@rmg rmg changed the title Lint source code and support Node.js 0.12.x and io.js 1.6.x Lint and test on Node.js 0.12.x and io.js 1.6.x Apr 1, 2015
rmg added a commit that referenced this pull request Apr 1, 2015
Lint and test on Node.js 0.12.x and io.js 1.6.x
@rmg rmg merged commit e5830fd into strongloop:master Apr 1, 2015
@rmg rmg removed the #community label Apr 1, 2015
@e-jigsaw
Copy link
Contributor Author

e-jigsaw commented Apr 2, 2015

@rmg thanks 👍

@e-jigsaw e-jigsaw deleted the support-newer branch April 2, 2015 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants