Cache results of md5 calls

strongloop · Aug 24, 2016 · 91ae698 · 91ae698
1 parent 33c3076
commit 91ae698
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/globalize.js b/lib/globalize.js
@@ -13,6 +13,7 @@ var helper = require('./helper');
 var osLocale = require('os-locale');
 var MapCache = require('lodash/_MapCache');
 var md5 = require('md5');
+var memoize = require('lodash/memoize');
 var pathUtil = require('path');
 var translate = require('./translate');
 var util = require('util');
@@ -117,9 +118,10 @@ function setDefaultLanguage(lang) {
  */
 function formatMessage(path, variables, lang) {
   assert(path);
-  var message = path;
-  if (helper.hashKeys(path)) path = md5(path);
   if (!global.STRONGLOOP_GLB) setDefaultLanguage();
+  var message = path;
+  if (helper.hashKeys(path))
+    path = global.STRONGLOOP_GLB.getHash(path);
   lang = lang || global.STRONGLOOP_GLB.DEFAULT_LANG;
   debug('~~~ lang = %s %s %j %s', lang, path, variables, __filename);
   var trailer = helper.getTrailerAfterDot(path);
@@ -382,6 +384,7 @@ function loadGlobalize(lang, enumerateNodeModules) {
       versionG: versionG,
       bundles: {},
       formatters: new MapCache(),
+      getHash: memoize(md5),
       load: Globalize.load,
       locale: Globalize.locale,
       loadMessages: Globalize.loadMessages,

diff --git a/package.json b/package.json
@@ -42,7 +42,7 @@
     "g11n-pipeline": "^1.2.2",
     "globalize": "^1.1.0",
     "htmlparser2": "^3.9.0",
-    "lodash": "^4.3.0",
+    "lodash": "^4.15.0",
     "md5": "^2.0.0",
     "mkdirp": "^0.5.1",
     "mktmpdir": "^0.1.1",