tag go module v0.1.0 #10
Assignees
Comments
enr0n
added a commit
that referenced
this issue
Jan 1, 2020
Initialize go module as github.com/strongswan/govici, and set minimum Go version to 1.11. While migrating to modules, create subdirectory vici/ so that the package can have a canonical import path. While this does require users to change their import path, the impact is minimal. Finally, update any references to the old import path in README.md and docs/getting_started.md. Related: #10 Signed-off-by: Nick Rosbrook <nr@enr0n.net>
enr0n
added a commit
that referenced
this issue
Jan 6, 2020
Initialize go module as github.com/strongswan/govici, and set minimum Go version to 1.11. While migrating to modules, create subdirectory vici/ so that the package can have a canonical import path. While this does require users to change their import path, the impact is minimal. Finally, update any references to the old import path in README.md and docs/getting_started.md. Related: #10 Signed-off-by: Nick Rosbrook <nr@enr0n.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Moving to Go modules is straight forward, but one thing to consider is whether this package should change its import path. Right now, we do not use the canonical import path (a vestige from before moving the package to its final home). This means that if your source files are
goimports -s-ed, then you have:Since this is not best practice for a package, I would like to use migration to Go modules as an opportunity to make sure this package does follow best practices.
I think the simplest option is to initialize the go module as
github.com/strongswan/govici, and move the existing *.go files tovici/sub-directory. This does mean that existing users of the package will have to change their import paths togithub.com/strongswan/govici/viciwhen they uprev tov0.1.0.The text was updated successfully, but these errors were encountered: