Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use EINVAL instead of EBADFD (not in POSIX) #235

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

omar-polo
Copy link
Contributor

EBADFD is not defined on OpenBSD (and judging at their errno(2) pages, neither on FreeBSD nor NetBSD.)

There's EBADF but it means 'bad file descriptor', and usually it means that you passed something that wasn't a file descriptor, so I picked EINVAL.

Copy link
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for highlighting this! We should maybe have CI runs on the BSDs as well.

I just thought whether it wouldn't be better to simply set conn->error to ret resp. err. (In the spirit of all the other "conn interfaces", since they already do that.)

@sjaeckel sjaeckel mentioned this pull request Feb 5, 2024
@sjaeckel sjaeckel merged commit 9410530 into strophe:master Feb 5, 2024
48 checks passed
@sjaeckel
Copy link
Member

sjaeckel commented Feb 5, 2024

Can I wait a few more days/weeks for a new release, so we can see whether there's other issues popping up?

@omar-polo
Copy link
Contributor Author

Sure, I can live with a local patch, and it won't prevent the package from being updated on OpenBSD. just fyi: all tests are passing here as usual :)

Thanks!

@sjaeckel sjaeckel added this to the next milestone Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants